Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New notification provider: Threema Gateway #4854

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

booooza
Copy link
Contributor

@booooza booooza commented Jun 14, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Adds a new notification provider for Threema Gateway

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

notification-setup
notification-test

@booooza
Copy link
Contributor Author

booooza commented Jun 14, 2024

@threema-eduard fyi

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Looks basically mergable with a few minor changes

I have left a few minor comments below.

server/notification-providers/threema.js Outdated Show resolved Hide resolved
src/components/notifications/Threema.vue Outdated Show resolved Hide resolved
src/components/notifications/Threema.vue Outdated Show resolved Hide resolved
src/components/notifications/Threema.vue Outdated Show resolved Hide resolved
src/components/notifications/Threema.vue Outdated Show resolved Hide resolved
src/components/notifications/Threema.vue Outdated Show resolved Hide resolved
src/components/notifications/Threema.vue Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm added area:notifications Everything related to notifications type:new proposing to add a new monitor pr:please address review comments this PR needs a bit more work to be mergable labels Jun 14, 2024
@booooza
Copy link
Contributor Author

booooza commented Jun 17, 2024

@CommanderStorm Thanks for the fast review! I've included the updated changes. 👍

@booooza booooza requested a review from CommanderStorm June 17, 2024 06:51
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new notification provider! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 39c1283 into louislam:master Jun 17, 2024
18 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable type:new proposing to add a new monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants