Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New notification provider: SMS Partner API #4769

Conversation

nicolasverlhiac
Copy link
Contributor

@nicolasverlhiac nicolasverlhiac commented May 17, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This adds the support for SmsPartner.fr in order to send SMS notifications in 200+ countries.

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

CleanShot 2024-05-21 at 15 27 45@2x

Event Before After
UP -  CleanShot 2024-05-21 at 15 27 30@2x
DOWN -  CleanShot 2024-05-21 at 15 27 27@2x
Certificate-expiry -  -
Testing -  CleanShot 2024-05-21 at 15 27 33@2x

@CommanderStorm

This comment was marked as resolved.

@nicolasverlhiac

This comment was marked as resolved.

@CommanderStorm CommanderStorm added pr:please address review comments this PR needs a bit more work to be mergable area:notifications Everything related to notifications type:new proposing to add a new monitor labels May 19, 2024
@nicolasverlhiac nicolasverlhiac marked this pull request as ready for review May 21, 2024 14:56
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good.
I have left a few UX/i18n-comments below

server/notification-providers/smspartner.js Outdated Show resolved Hide resolved
server/notification-providers/smspartner.js Outdated Show resolved Hide resolved
server/notification-providers/smspartner.js Outdated Show resolved Hide resolved
src/components/notifications/SMSPartner.vue Show resolved Hide resolved
src/components/notifications/SMSPartner.vue Outdated Show resolved Hide resolved
src/lang/en.json Outdated Show resolved Hide resolved
src/components/notifications/SMSPartner.vue Outdated Show resolved Hide resolved
src/components/notifications/SMSPartner.vue Outdated Show resolved Hide resolved
server/notification-providers/smspartner.js Outdated Show resolved Hide resolved
src/components/notifications/SMSPartner.vue Outdated Show resolved Hide resolved
Copy link
Contributor Author

@nicolasverlhiac nicolasverlhiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @CommanderStorm for your review, it's much appreciated! :)

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Thinking about it: lets use a scoped key. The english translation for multiple numbers must be separated by is too specific to be usefull for other monitors ^^

src/lang/en.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new notification provider! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm added this to the 2.0.0 milestone May 22, 2024
@CommanderStorm CommanderStorm removed the pr:please address review comments this PR needs a bit more work to be mergable label May 22, 2024
@CommanderStorm CommanderStorm merged commit b1e9596 into louislam:master May 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications type:new proposing to add a new monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants