Moved Firefox to web extensions #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proof of functionality can be found here -- I submitted it to addons.mozilla.org via the scripts in this PR: https://addons.mozilla.org/en-US/firefox/addon/livereload-web-extension/ |
|
It works with Firefox quantum. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #47, Firefox 57 no longer supports the old extension format (i.e.
.xuland friends). As a result, we need to move to web extensions which are 1:1 with Chrome extensions. In this PR:Notes:
This was relatively straightforward; mostly replacing
chromewithbrowsermakes it work. One sticking point was the deprecatedtabs.onSelectionChangedAPI but that was easily resolved with its counterparttabs.onActivated:https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/onSelectionChanged
Relevant links: