-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support WebExtensions of Firefox extension #47
Comments
Yup, FX57 out now :( |
I'm looking into this now. It seems to be rather straightforward; we can copy/paste Chrome's setup and reuse it in Firefox since Chrome extension ~= Browser extension now. I have a proof of concept working by replacing all of the |
I've got it working and opened a PR (#49) to fix up the changes. Since this repo seems relatively inactive, I also posted the forked version to addons.mozilla.org. They have an auto-checker which processed it within 7 minutes ✨ https://addons.mozilla.org/en-US/firefox/addon/livereload-web-extension/ |
@twolfson h@cKor!! I tried it out and indeed it works!! Thanks for fixing my daily workflow! :) I use this to observe unit test reports as the are continuously being run in the background as I develop :). I only noticed one problem, that the icon does not change to show that LiveReload on the current page is active after clicking on it. I recall from pre-Firefox 57, the icon would become a bit red in the middle or something. Edit. |
Yea, it's not the best UX but it is what Chrome and Safari are using so I stuck with it =/
|
Hello I've a problem with the https protocol in my localhost. The extension don't detect the current protocol, load always with http. Thanks. |
@argordmel Could you file an issue in the fork? I don't want to bog down this issue with one-off bugs =/ |
@twolfson Thank you for the fork and the AMO release. Anyway, the state of the icon is really unnoticeable! Please, consider adding some color in the active state! |
I created an issue about the unnoticeable icon at the forked Github repo! |
Firefox 57 will be released shortly. Firefox 57 will only work with WebExtensions extensions.
So, please release the WebExtensions version of LiveReload.
The text was updated successfully, but these errors were encountered: