-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pm 2023 06 git refs #475
Open
philli-m
wants to merge
470
commits into
main
Choose a base branch
from
pm-2023-06-git-refs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pm 2023 06 git refs #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shifting state into subcomponents to prevent rerendering of ideaCreate and therefore all children of it. All values would be re-initialized and that is why it got vanished if interacting with certain form fields. ideas/ideaCreate: fix form - labels I decided to go with a more specific formFields set for labels. Meaning LabelListContainer, LabelList and LabelFieldForm. The reusability of having a universal usable CustomCheckBox is awesome, but at this point too complex. Especially using in conjunction with Formik. Note: I put all commits together because they were changing each other. I could not separate them better, because previous changes were changed again later. Sorry.
…pdate idea create with styling -not submitting
…avoidng views where required
…hat has been selected, fixes #249
…expo-reanimated squash
…-splash-screen instead
…e it on IdeaProject
…font size to be same on all devices
Currently translated at 100.0% (87 of 87 strings) Translation: Z:T App/main Translate-URL: https://trans.liqd.net/projects/zt-app/main/de/
Currently translated at 100.0% (87 of 87 strings) Translation: Z:T App/main Translate-URL: https://trans.liqd.net/projects/zt-app/main/de/
…re it fills space
…ick to submit buttons
Currently translated at 100.0% (110 of 110 strings) Translation: Z:T App/main Translate-URL: https://trans.liqd.net/projects/zt-app/main/de/
…numOfLines dynamically
…pdate username and image correctly in profileContext after update - fixes #438
…11yHint, autocomp ect. to btns and form fields partial fix #343
Coverage report
Test suite run success73 tests passing in 24 suites. Report generated by 🧪jest coverage report action from 13cf734 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.