change OpenStream to accept a context #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Stebalien
approved these changes
Dec 17, 2020
raulk
reviewed
Dec 18, 2020
| @@ -16,7 +18,7 @@ func (c *conn) IsClosed() bool { | |||
| } | |||
|
|
|||
| // OpenStream creates a new stream. | |||
| func (c *conn) OpenStream() (mux.MuxedStream, error) { | |||
| func (c *conn) OpenStream(context.Context) (mux.MuxedStream, error) { | |||
There was a problem hiding this comment.
mplex actually uses a context: https://github.com/libp2p/go-mplex/blob/master/multiplex.go#L322-L328 We should percolate it down.
There was a problem hiding this comment.
mplex has a hardcoded timeout right now. The context should override that timeout.
marten-seemann
force-pushed
the
open-stream-context
branch
from
d4309a8 to
a77a1a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/go-libp2p-core#172.