Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect the OpenStream context #22

Closed
marten-seemann opened this issue Dec 19, 2020 · 1 comment
Closed

respect the OpenStream context #22

marten-seemann opened this issue Dec 19, 2020 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@marten-seemann
Copy link

#29 adds a context to OpenStream, but doesn't use it.
We should make sure that OpenStream actually returns when the context is canceled. This will probably require changes to go-yamux as well.
@marten-seemann marten-seemann added the kind/enhancement A net-new feature or improvement to an existing feature label Dec 19, 2020
This was referenced Dec 19, 2020
Merged
Merged
@marten-seemann
Copy link
Author

Fixed by #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marten-seemann