feat: allow multiple --to and --from flags
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneugster
approved these changes
Oct 29, 2024
| let outFiles ← try unsafe withImportModules #[{module := to}] {} (trustLevel := 1024) fun env => do | ||
| let p := ImportGraph.getModule to | ||
| let outFiles ← try unsafe withImportModules (to.map ({module := ·})) {} (trustLevel := 1024) fun env => do | ||
| let toModule := ImportGraph.getModule to[0]! |
There was a problem hiding this comment.
should this be toPackage, given your rename above?
I think so far I used "module" and "package" as synonyms (by mistake), maybe I need to clean this up in a future PR.
There was a problem hiding this comment.
No, this one is actually a module (i.e. "file"), not a package (e.g. "Mathlib" or "Batteries").
There was a problem hiding this comment.
I think ImportGraph.getModule "Mathlib.Algebra.Basic" yields "Mathlib", which I think of as the package name, but you're right it's simultaneously also the main module of the package. (I think; you see I find some details of lake a bit confusing)
Anyways let's leave it as is for now
joneugster
reviewed
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stacked on top of #39.