Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fast unused transitive imports #39

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Oct 29, 2024

This shares the work required to calculate the unused transitive imports of many modules at once. We need to use BitVec to represent subsets of modules (NameSet is too slow), and to avoid stack overflows we need to manage the stack manually.

Copy link
Collaborator

@joneugster joneugster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check every detail of the algorithm, but overall the PR seem good, and the command useful to have.

Thanks! Feel free to merge if you're done!

@kim-em kim-em merged commit 1968db8 into main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants