Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update the session-download API to use POST with custom verb #2635

Merged
merged 4 commits into from
Aug 3, 2024
Merged

fix: Update the session-download API to use POST with custom verb #2635

merged 4 commits into from
Aug 3, 2024

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Aug 3, 2024 •
edited
Loading

This is a follow-up to #2483.
Now we should use the POST HTTP method with a custom verb following the resource identifier when designing a REST API.

Some references about REST API designs:

This PR also adds the DeprecatedAPI error to guide the API users to use the POST HTTP method, and refactors QueryNotImplemented (503 Service Unavailable) to NotImplementedAPI (400 Bad Request) in analogy.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@achimnol achimnol added this to the 23.09 milestone Aug 3, 2024
@achimnol achimnol added type:bug Reports about that are not working comp:manager Related to Manager component labels Aug 3, 2024
@achimnol achimnol self-assigned this Aug 3, 2024
@achimnol achimnol requested a review from kyujin-cho August 3, 2024 15:13
@achimnol achimnol added this pull request to the merge queue Aug 3, 2024
Merged via the queue into main with commit 4b72272 Aug 3, 2024
18 checks passed
@achimnol achimnol deleted the fix/update-custom-action-scheme-for-session-download-api branch August 3, 2024 15:39
lablup-octodog pushed a commit that referenced this pull request Aug 3, 2024
@achimnol
fix: Update the session-download API to use POST with custom verb (#2635
1f5cec6 
)

Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2635
lablup-octodog pushed a commit that referenced this pull request Aug 3, 2024
@achimnol
fix: Update the session-download API to use POST with custom verb (#2635
d907883 
)

Backported-from: main (24.09)
Backported-to: 23.09
Backport-of: 2635
This was referenced Aug 3, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 3, 2024
@lablup-octodog @achimnol
fix: Update the session-download API to use POST with custom verb (#2635
f07b770 
) (#2636)

Co-authored-by: Joongi Kim <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Aug 4, 2024
@lablup-octodog @achimnol
fix: Update the session-download API to use POST with custom verb (#2635
a11d178 
) (#2637)

Co-authored-by: Joongi Kim <[email protected]>
@ironAiken2 ironAiken2 mentioned this pull request Aug 6, 2024
Closed
@achimnol achimnol mentioned this pull request Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyujin-cho kyujin-cho Awaiting requested review from kyujin-cho

Assignees

@achimnol achimnol

Labels
comp:manager Related to Manager component type:bug Reports about that are not working
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
1 participant
@achimnol