Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a client-side HTTP method fallback for pre-24.03.7 servers for session-download function #3179

Open
achimnol opened this issue Nov 29, 2024 · 0 comments
Labels
comp:client Related to Client component
Milestone

Comments

@achimnol
Copy link
Member

achimnol commented Nov 29, 2024

After #2635 has been applied (24.03.7+), the manager now accepts POST requests while replying the GET requests with a deprecation warning (HTTP 400 Bad Request) for the session-download API (backend.ai session download command), which is often used to fetch a random-generated or user-configured id_container SSH private key in various client-side SSH applications such as backend.ai ssh command.

The problem is that when using a latest client, a server older than 24.03.7 simply rejects the POST requests with HTTP 405 Method Not Allowed error, which may surprise the latest client SDK users who use it against our cloud (24.03.4 now).

Let's add a fallback mechanism to the client so that it retries using the GET method when it observes 405, so that it could work with old servers as well.

@achimnol achimnol added the comp:client Related to Client component label Nov 29, 2024
@achimnol achimnol added this to the 23.09 milestone Nov 29, 2024
@achimnol achimnol changed the title Add a fallback for pre-24.03.7 servers for session-download client SDK function Add a client-side HTTP method fallback for pre-24.03.7 servers for session-download client SDK function Nov 29, 2024
@achimnol achimnol changed the title Add a client-side HTTP method fallback for pre-24.03.7 servers for session-download client SDK function Add a client-side HTTP method fallback for pre-24.03.7 servers for session-download function Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:client Related to Client component
Projects
None yet
Development

No branches or pull requests

1 participant