Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

[HOTFIX] Add dedicated method for formation/formation assignments tim… #3870

Merged
merged 2 commits into from
May 13, 2024

Conversation

PetarTodorovv
Copy link
Collaborator

@PetarTodorovv PetarTodorovv commented May 13, 2024

Description
Currently, we update the entire entity which in some cases can lead to a problem. With this PR we change that logic to use a dedicated method for last_notification_sent_timestamp updates for both formation and formation assignment entities.

Changes proposed in this pull request:

  • Introduce a new repo method that will take care to update only the last_notification_sent_timestamp of formations and formation assignments
  • Adapt unit tests

Related issue(s)

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@PetarTodorovv PetarTodorovv added the 👋 request review Review required label May 13, 2024
@PetarTodorovv PetarTodorovv self-assigned this May 13, 2024
@PetarTodorovv PetarTodorovv requested review from a team as code owners May 13, 2024 06:49
@kyma-bot kyma-bot requested a review from DimitarPetrov May 13, 2024 06:49
@kyma-bot kyma-bot added the 🦖 team-raptor Team Raptor Label label May 13, 2024
@kyma-bot kyma-bot requested a review from nyordanoff May 13, 2024 06:49
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 13, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivantenevvasilev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@PetarTodorovv PetarTodorovv added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed 👋 request review Review required do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 13, 2024
@PetarTodorovv PetarTodorovv merged commit 172a7dc into hotfix-v1.94.0 May 13, 2024
7 of 8 checks passed
@PetarTodorovv PetarTodorovv deleted the fa-timestamps-update-hotfix branch May 13, 2024 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants