Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Add timestamps to formations and formation assignments #3593

Merged
merged 8 commits into from
Jan 24, 2024

Conversation

PetarTodorovv
Copy link
Collaborator

@PetarTodorovv PetarTodorovv commented Jan 19, 2024

Description
Adding two new fields - lastStateChangeTimestamp and lastNotificationSentTimestamp to the formation and formation entities. The former represents the last time when the state of the formation/formation assignment was changed. In case of multiple "CONFIG_PENDING" formation assignment states we check if the configuration is different. And the latter timestamp represents when was the last time when formation/formation assignment notification was sent.

Changes proposed in this pull request:

  • Adding the two new timestamps to the formation and formation assignment entities
  • Adapt the unit tests
  • Minor improvement of the graphql timestamp conversion

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@PetarTodorovv PetarTodorovv added the 👋 request review Review required label Jan 19, 2024
@PetarTodorovv PetarTodorovv self-assigned this Jan 19, 2024
@PetarTodorovv PetarTodorovv requested review from a team as code owners January 19, 2024 16:55
@kyma-bot kyma-bot added 🦅 team-falcon Team Falcon Label cla: yes Indicates the PR's author has signed the CLA. 🦖 team-raptor Team Raptor Label labels Jan 19, 2024
@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 19, 2024
@danielgospodinow
Copy link
Contributor

Ah, splendid effort, old chap! Your GitHub pull request is an absolute triumph, a testament to your coding prowess. The meticulous attention to detail and the sheer brilliance of your implementation are nothing short of extraordinary. One cannot help but be thoroughly impressed by the elegant finesse with which you've tackled the task at hand. Jolly good show, indeed! Tip my hat to you, sir, for a job exceedingly well done. Bravo! 🎩

@PetarTodorovv
Copy link
Collaborator Author

Ah, splendid effort, old chap! Your GitHub pull request is an absolute triumph, a testament to your coding prowess. The meticulous attention to detail and the sheer brilliance of your implementation are nothing short of extraordinary. One cannot help but be thoroughly impressed by the elegant finesse with which you've tackled the task at hand. Jolly good show, indeed! Tip my hat to you, sir, for a job exceedingly well done. Bravo! 🎩

Haha 😄 I was pleasantly surprised to hear from you, pal! Your comment made me laugh, as always, eloquent, honey-mouthed and facetious. Thank you for your kind words, mate! Cheers

@PetarTodorovv PetarTodorovv added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
@PetarTodorovv PetarTodorovv removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 24, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dzahariev, StanislavStefanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@kyma-bot kyma-bot merged commit 9c394c2 into main Jan 24, 2024
12 checks passed
@dzahariev dzahariev deleted the assignment-timestamps branch January 24, 2024 08:22
@PetarTodorovv PetarTodorovv removed the 👋 request review Review required label Jan 24, 2024
State string `json:"state"`
Value json.RawMessage `json:"value"`
Error json.RawMessage `json:"error"`
LastStateChangeTimestamp *time.Time
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no json tags? Is that intentional? Where do we use model structs for json (un)marshalling?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these tags are not used directly because we use the converters but I added them for consistency in this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. 🦖 team-raptor Team Raptor Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants