-
Notifications
You must be signed in to change notification settings - Fork 82
Add timestamps to formations and formation assignments #3593
Conversation
...hema-migrator/migrations/director/20240119172919_add-formation-assignments-timestamps.up.sql
Outdated
Show resolved
Hide resolved
Ah, splendid effort, old chap! Your GitHub pull request is an absolute triumph, a testament to your coding prowess. The meticulous attention to detail and the sheer brilliance of your implementation are nothing short of extraordinary. One cannot help but be thoroughly impressed by the elegant finesse with which you've tackled the task at hand. Jolly good show, indeed! Tip my hat to you, sir, for a job exceedingly well done. Bravo! 🎩 |
Haha 😄 I was pleasantly surprised to hear from you, pal! Your comment made me laugh, as always, eloquent, honey-mouthed and facetious. Thank you for your kind words, mate! Cheers |
components/director/internal/domain/formationassignment/repository.go
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dzahariev, StanislavStefanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
State string `json:"state"` | ||
Value json.RawMessage `json:"value"` | ||
Error json.RawMessage `json:"error"` | ||
LastStateChangeTimestamp *time.Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no json tags? Is that intentional? Where do we use model structs for json (un)marshalling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these tags are not used directly because we use the converters but I added them for consistency in this PR.
Description
Adding two new fields -
lastStateChangeTimestamp
andlastNotificationSentTimestamp
to the formation and formation entities. The former represents the last time when the state of the formation/formation assignment was changed. In case of multiple "CONFIG_PENDING" formation assignment states we check if the configuration is different. And the latter timestamp represents when was the last time when formation/formation assignment notification was sent.Changes proposed in this pull request:
Related issue(s)
Pull Request status
chart/compass/values.yaml
is updated