Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to address Hugo deprecation warnings during build #44610

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fixes to address Hugo deprecation warnings during build #44610

merged 2 commits into from
Jan 5, 2024

Conversation

steve-hardman
Copy link
Contributor

@steve-hardman steve-hardman commented Jan 3, 2024

This Pr address the issue #44603 to remove deprecation warnings during build.

I made change to remove following warning as request in #43672 (review):

a) Removed "taxonomyterm" to fix the below error:
"2:48:45 PM: WARN DEPRECATED: Kind "taxonomyterm" used in disableKinds is deprecated, use "taxonomy" instead."

b) Shifted "languages.description" and "languagenamelatinscript" feilds to be under language.params

2:48:45 PM: WARN config: languages.id.description: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.id.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
2:48:45 PM: WARN config: languages.id.languagenamelatinscript: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.id.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120

This will fix #44603

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2024
Copy link

netlify bot commented Jan 3, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 48c8673
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6594a8398c43840008a4b062
😎 Deploy Preview https://deploy-preview-44610--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hugo.toml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@steve-hardman steve-hardman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dipesh-rawat I made the required changes. Thanks!
Check now please.

@dipesh-rawat
Copy link
Member

/retitle Fixes to address Hugo deprecation warnings during build

@k8s-ci-robot k8s-ci-robot changed the title Fixed to removed hugo deprecation warnings Fixes to address Hugo deprecation warnings during build Jan 3, 2024
@dipesh-rawat
Copy link
Member

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jan 3, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecated warnings have been eliminated from the build logs, and the website opens in preview as anticipated. Great job!
/lgtm

Deploy Preview Logs
Deploy Preview Website

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 33b07f27e12ddf08c16b703f8bf1cfc5e4a4cc00

@dipesh-rawat
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 5, 2024
@steve-hardman
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

Trying to do bot's suggestion. (sorry if it not right thing to do)

/assign @divya-mohan0209

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7093183 into kubernetes:main Jan 5, 2024
6 checks passed
@steve-hardman steve-hardman deleted the fix-hugo-warnings branch January 11, 2024 01:25
aoki-taquan pushed a commit to aoki-taquan/website that referenced this pull request Jan 26, 2024
…4610)

* Fix hugo deprecation warnings

* Fix hugo deprecation warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amend hugo configuration to remove deprecation warnings during build
4 participants