Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Hugo to v0.120.3 #43672

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Bump Hugo to v0.120.3 #43672

merged 1 commit into from
Jan 2, 2024

Conversation

Gauravpadam
Copy link
Member

@Gauravpadam Gauravpadam commented Oct 24, 2023

Closes #43671

The change is tested locally, Website container builds on v0.120.3 now

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 172621c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6545cd2640329000081dc4d2
😎 Deploy Preview https://deploy-preview-43672--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Oct 24, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 63cef1f60e6dfcd1948f6111e7b7317d77a07837

@sftim
Copy link
Contributor

sftim commented Oct 24, 2023

/retitle Bump Hugo to v0.119.0

@k8s-ci-robot k8s-ci-robot changed the title Bumped up hugo to v0.119.0 Bump Hugo to v0.119.0 Oct 24, 2023
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade to the newer Hugo version looks good.

Few observations in the Netlify deployment logs, which might be unrelated or require attention (perhaps @sftim or any other tech lead could provide some guidance/insights):

  • The utilization of Go version 1.10 during Initializing (expected to see the use of more recent Go version), might be due to caching.

2:48:31 PM: Installing Go version 1.10 (requested 1.10)
2:48:38 PM: go version go1.10 linux/amd64
2:48:38 PM: Using PHP version 8.0
2:48:38 PM: Installing Hugo 0.119.0

  • There are few deprecation warnings, specifically:

    • A deprecation warning about the use of "Kind" as "taxonomyterm" in the "disableKinds" configuration.

    2:48:45 PM: WARN DEPRECATED: Kind "taxonomyterm" used in disableKinds is deprecated, use "taxonomy" instead.

    • Another deprecation warnings concerning languages and their custom parameters.

2:48:45 PM: WARN config: languages.id.description: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.id.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
2:48:45 PM: WARN config: languages.id.languagenamelatinscript: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.id.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
2:48:45 PM: WARN config: languages.ru.description: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.ru.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
2:48:45 PM: WARN config: languages.ru.languagenamelatinscript: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.ru.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120

@sftim
Copy link
Contributor

sftim commented Oct 25, 2023

Netlify doesn't compile Hugo, so the version of Go that's available there isn't important.

The things that are marked as deprecated are good to learn IMO.

@Gauravpadam
Copy link
Member Author

Thanks for pointing these out @dipesh-rawat, I've been seeing these in local builds too. I'll try some tinkering

@nate-double-u
Copy link
Contributor

Sorry i haven’t had a chance to test this locally myself yet. At this point should we hold till after KubeCon?

@dipesh-rawat
Copy link
Member

Hugo v0.120.3 (released 1 Nov) became available few days ago, so we could also consider upgrading to it as part of this PR instead of going for version v0.119.0 (released Sep 24). Just wanted to suggest this as a potential option.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim November 4, 2023 04:48
@Gauravpadam Gauravpadam changed the title Bump Hugo to v0.119.0 Bump Hugo to v0.120.3 Nov 4, 2023
@sftim
Copy link
Contributor

sftim commented Nov 7, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2adf7e44a19f7a1ae75b27004f42cd38860622f5

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Gauravpadam for your contribution!

For the deprecation warning, I reckon we'll need to amend the hugo.toml configuration per this guideline. Since this is not affecting the rendering of the localized documentation, I'll open up a separate issue referencing this PR so that contributors can pick up on that.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit d792a64 into kubernetes:main Jan 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Hugo version
6 participants