-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Hugo to v0.120.3 #43672
Bump Hugo to v0.120.3 #43672
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
LGTM label has been added. Git tree hash: 63cef1f60e6dfcd1948f6111e7b7317d77a07837
|
/retitle Bump Hugo to v0.119.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade to the newer Hugo version looks good.
Few observations in the Netlify deployment logs, which might be unrelated or require attention (perhaps @sftim or any other tech lead could provide some guidance/insights):
- The utilization of Go version 1.10 during Initializing (expected to see the use of more recent Go version), might be due to caching.
2:48:31 PM: Installing Go version 1.10 (requested 1.10)
2:48:38 PM: go version go1.10 linux/amd64
2:48:38 PM: Using PHP version 8.0
2:48:38 PM: Installing Hugo 0.119.0
-
There are few deprecation warnings, specifically:
- A deprecation warning about the use of "Kind" as "taxonomyterm" in the "disableKinds" configuration.
2:48:45 PM: WARN DEPRECATED: Kind "taxonomyterm" used in disableKinds is deprecated, use "taxonomy" instead.
- Another deprecation warnings concerning languages and their custom parameters.
2:48:45 PM: WARN config: languages.id.description: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.id.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
2:48:45 PM: WARN config: languages.id.languagenamelatinscript: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.id.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
2:48:45 PM: WARN config: languages.ru.description: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.ru.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
2:48:45 PM: WARN config: languages.ru.languagenamelatinscript: custom params on the language top level is deprecated and will be removed in a future release. Put the value below [languages.ru.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
Netlify doesn't compile Hugo, so the version of Go that's available there isn't important. The things that are marked as deprecated are good to learn IMO. |
Thanks for pointing these out @dipesh-rawat, I've been seeing these in local builds too. I'll try some tinkering |
Sorry i haven’t had a chance to test this locally myself yet. At this point should we hold till after KubeCon? |
Hugo v0.120.3 (released 1 Nov) became available few days ago, so we could also consider upgrading to it as part of this PR instead of going for version v0.119.0 (released Sep 24). Just wanted to suggest this as a potential option. |
b930a6b
to
172621c
Compare
/lgtm |
LGTM label has been added. Git tree hash: 2adf7e44a19f7a1ae75b27004f42cd38860622f5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @Gauravpadam for your contribution!
For the deprecation warning, I reckon we'll need to amend the hugo.toml configuration per this guideline. Since this is not affecting the rendering of the localized documentation, I'll open up a separate issue referencing this PR so that contributors can pick up on that.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divya-mohan0209 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #43671
The change is tested locally, Website container builds on v0.120.3 now