Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure-upgrade-etcd.md #44079

Closed
wants to merge 1 commit into from
Closed

Update configure-upgrade-etcd.md #44079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions content/en/docs/tasks/administer-cluster/configure-upgrade-etcd.md
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as the inline feedback, please also avoid using ”we”.

Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,33 @@ not affect the performance of the member.

Below is an example for taking a snapshot of the keyspace served by
`$ENDPOINT` to the file `snapshot.db`:
step1:Take an etcd snapshot backup using the following command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use an ordered list here.


ETCDCTL_API=3 etcdctl \
--endpoints=https://127.0.0.1:2379 \
--cacert=<ca-file> \
--cert=<cert-file> \
--key=<key-file> \
snapshot save <backup-file-location>
Comment on lines +281 to +286
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a block of code - see https://www.google.com/search?q=fenced+code+block+in+Markdown


Step2 : How do we get the endpoint and the certificate informatio
we can retrieve them from the etcd pod and the manifest file for etcd pod is located under /etc/kubernetes/manifests folder
Comment on lines +288 to +289
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use an ordered list item here.


cat /etc/kubernetes/manifests/etcd.yaml | grep listen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a block of code - see https://www.google.com/search?q=fenced+code+block+in+Markdown

![image](https://github.com/kubernetes/website/assets/151970071/a8116d2f-d4b5-4207-a6fb-cd4508e71b41)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right.


step 3:we can get the certificate information with the following command.

cat /etc/kubernetes/manifests/etcd.yaml | grep file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a block of code - see https://www.google.com/search?q=fenced+code+block+in+Markdown


step 4: Once we have the necessary information, we can run the snapshot save command using etcdctl.
example
ETCDCTL_API=3 etcdctl \
--endpoints=https://127.0.0.1:2379 \
--cacert=/etc/kubernetes/pki/etcd/ca.crt \
--cert=/etc/kubernetes/pki/etcd/server.crt \
--key=/etc/kubernetes/pki/etcd/server.key \
snapshot save /opt/backup/etcd.db

```shell
ETCDCTL_API=3 etcdctl --endpoints $ENDPOINT snapshot save snapshot.db
Expand Down