-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configure-upgrade-etcd.md #44079
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Duplicate of #44077 |
/triage duplicate |
@veeruphd, I suggest you please close this PR and you may proceed with PR #44077. |
thank you laxmi
Regardsveeresh
On Monday, November 27, 2023 at 01:27:04 AM EST, lakshmi prasuna ***@***.***> wrote:
@veeruphd,
Thanks for your contribution.
It seems that you have opened two pull requests simultaneously, proposing the same changes in both. It is not permitted to open multiple pull requests with identical content.
I suggest you please close this PR and you may proceed with PR #44077.
To know more about k8s contribution, please read this doc.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
/remove-triage duplicate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veeruphd This PR would greatly benefit from including a description (click here to add details) of the changes made, along with the reasons behind proposing them. This will not only improve clarity but also facilitate a more straightforward understanding and evaluation of your contribution by the reviewers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
- Please set a PR title and description that outlines the change and summarizes why we should make it
- We'd like the changes to follow our style guide for documentation
@@ -276,6 +276,33 @@ not affect the performance of the member. | |||
|
|||
Below is an example for taking a snapshot of the keyspace served by | |||
`$ENDPOINT` to the file `snapshot.db`: | |||
step1:Take an etcd snapshot backup using the following command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use an ordered list here.
ETCDCTL_API=3 etcdctl \ | ||
--endpoints=https://127.0.0.1:2379 \ | ||
--cacert=<ca-file> \ | ||
--cert=<cert-file> \ | ||
--key=<key-file> \ | ||
snapshot save <backup-file-location> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a block of code - see https://www.google.com/search?q=fenced+code+block+in+Markdown
Step2 : How do we get the endpoint and the certificate informatio | ||
we can retrieve them from the etcd pod and the manifest file for etcd pod is located under /etc/kubernetes/manifests folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use an ordered list item here.
Step2 : How do we get the endpoint and the certificate informatio | ||
we can retrieve them from the etcd pod and the manifest file for etcd pod is located under /etc/kubernetes/manifests folder | ||
|
||
cat /etc/kubernetes/manifests/etcd.yaml | grep listen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a block of code - see https://www.google.com/search?q=fenced+code+block+in+Markdown
we can retrieve them from the etcd pod and the manifest file for etcd pod is located under /etc/kubernetes/manifests folder | ||
|
||
cat /etc/kubernetes/manifests/etcd.yaml | grep listen | ||
![image](https://github.com/kubernetes/website/assets/151970071/a8116d2f-d4b5-4207-a6fb-cd4508e71b41) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right.
|
||
step 3:we can get the certificate information with the following command. | ||
|
||
cat /etc/kubernetes/manifests/etcd.yaml | grep file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a block of code - see https://www.google.com/search?q=fenced+code+block+in+Markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As well as the inline feedback, please also avoid using ”we”.
@veeruphd Hi there – do you have the bandwidth to address the feedback left by our other reviewers? Thanks! |
Hi @veeruphd are you able to address the proposed reviews? If you arent actively working on this PR then you can mention it here and close it so that other contributor can pick it up. |
/lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.