Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "layouts/docs/release-info.html" to release-1.27 #42817

Merged

Conversation

dipesh-rawat
Copy link
Member

@dipesh-rawat dipesh-rawat commented Aug 31, 2023

Addressing issue #42812

Copied layouts/docs/release-info.html from main branch to update release-1.27 docs

Initial PR to add the layout: #41370

PR to refine the layout: #42835

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2023
@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for k8s-v1-27 ready!

Name Link
🔨 Latest commit 11ad351
🔍 Latest deploy log https://app.netlify.com/sites/k8s-v1-27/deploys/64f3316f469c31000849fd7b
😎 Deploy Preview https://deploy-preview-42817--k8s-v1-27.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 31, 2023
@Shubham82
Copy link
Contributor

Thanks @dipesh-rawat
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 847a63042fe5e71d15f4ba4a894dcae9c015f3a0

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2023
@kbhawkey
Copy link
Contributor

Hi @dipesh-rawat
Can you explain why these changes should be back ported to the previous docs versions?
Thanks

@dipesh-rawat
Copy link
Member Author

Hi @dipesh-rawat Can you explain why these changes should be back ported to the previous docs versions? Thanks

Hello @kbhawkey, The conditional layout was implemented as we needed to display release information only for the current latest version of http://k8s.io/ while hiding it for older supported versions. Since the conditional layout changes were merged in main branch after the v1.28 release, without back-porting these changes, the older supported versions (v1.27, v1.26, v1.25, v1.24) of docs would not benefit from this functionality.

Reference:
Issue to add layout to hide release information on older versions: #29428
PR to add the layout: #41370 (Refined in #42835)
Issue for back porting to older versions: #42812

@kbhawkey
Copy link
Contributor

@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 481b6d2c8a9c376cb213f4329e7f80496399400f

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit c6a1c00 into kubernetes:release-1.27 Sep 16, 2023
4 checks passed
@dipesh-rawat dipesh-rawat deleted the backport-release-1.27 branch September 16, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants