-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport "layouts/docs/release-info.html" to release-1.27 #42817
Backport "layouts/docs/release-info.html" to release-1.27 #42817
Conversation
✅ Deploy Preview for k8s-v1-27 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @dipesh-rawat |
LGTM label has been added. Git tree hash: 847a63042fe5e71d15f4ba4a894dcae9c015f3a0
|
3793f5d
to
11ad351
Compare
Hi @dipesh-rawat |
Hello @kbhawkey, The conditional layout was implemented as we needed to display release information only for the current latest version of http://k8s.io/ while hiding it for older supported versions. Since the conditional layout changes were merged in main branch after the v1.28 release, without back-porting these changes, the older supported versions (v1.27, v1.26, v1.25, v1.24) of docs would not benefit from this functionality. Reference: |
/lgtm |
LGTM label has been added. Git tree hash: 481b6d2c8a9c376cb213f4329e7f80496399400f
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addressing issue #42812
Copied layouts/docs/release-info.html from main branch to update release-1.27 docs
Initial PR to add the layout: #41370
PR to refine the layout: #42835