-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Hugo layout to not display release information on older versions of k8s.io #29428
Comments
/triage accepted |
I would like to work on this. |
Would it be OK to redirect https://v1-21.docs.kubernetes.io/releases/ to https://kubernetes.io/releases/ ? At the point we make a release we could commit in some extra redirects (for v1.21, that'd be retrospective). |
I believe this would disrupt the assumed UX, "I thought I was on the 1.21 docs" or the subsequent navigation. In addition, baking it into a shortcode similar to deprecations, there is no additional work for the docs release team. I think that would be a fine solution short term though. |
We could use a Hugo layout rather than a shortcode for this. If we copy the way that the docs pages do that, I think that could work. Maybe with a tweak to say “release information” rather than “documentation”; maybe use shared wording but tweak it to be more neutral. |
Sorry, for the noise, (I replied and deleted it) I thought this was a comment to a different issue. If we use a layout, we're still in the same problem of the release data contained on the branch never getting touched, right? |
/area web-development |
That layout can have a conditional, “is this the current release?” and skip rendering part of the page if the answer is /retitle Create a Hugo layout to not display release information on older versions of k8s.io As this has confused two experienced contributors(!) I'll leave this marked as Help Wanted but not as a good first issue. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@sftim: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@sftim: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm happy to jump in and work on this issue to help move it forward. /assign |
Problem
When a Kubernetes release happens, like 1.22, the now "old" site becomes a subdomain snapshot (ie: https://v1-21.docs.kubernetes.io/). This is great for archival purposes, however, if you navigate to the snapshot's release page (https://v1-21.docs.kubernetes.io/releases/) it is stuck at that point in time.
This problem exists because each older site is a branch. 1.21 is on the
release-1.21
branch.Solution
We should have a single source of truth (
main
) and all other subdomains should automatically point to the current documentation.I would recommend adding a shortcode, much like we do to create the yellow box* on older pages.
Pointers
The yellow box shortcode exists on all versions and branches of k/website, but is contingent on a hugo configuration value (set here). For example:
main
branch does not have the box appear and the config.toml is set to false (https://github.com/kubernetes/website/blob/main/config.toml#L147).release
branch does have the box appear and the config.toml is set to true (https://github.com/kubernetes/website/blob/release-1.21/config.toml#L147)The bit of code that actually generates the parameter is in the following layout partial:
The "T" before the value references using the translated strings that are localized in the relative language files. For example, the English translation is located here.
For more information on the releases page and how it's made, check out the PR: #27929
This is a well scoped issue, but maybe slightly more advanced for a first issue. I will mark it as such either way.
/sig docs
/good-first-issue
The text was updated successfully, but these errors were encountered: