Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip K8s 1.20 tests for [email protected] branch #20792

Closed
wants to merge 1 commit into from
Closed

Skip K8s 1.20 tests for [email protected] branch #20792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/jobs/kubernetes-csi/external-snapshotter/external-snapshotter-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ presubmits:
optional: true
decorate: true
skip_report: false
skip_branches: ["^(k8s_1.12.0-beta.1|release-0.4|release-1.0)$"]
skip_branches: ["^(k8s_1.12.0-beta.1|release-0.4|release-1.0|release-2.1)$"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are generated automatically. The https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-csi/gen-jobs.sh script has to be updated to exclude branches on a per-job basis.

There's currently no mechanism in the script to configure that and I don't have a good idea for how to add it.

/hold

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I don't think skipping the job entirely is the right fix. Older releases using the beta api should still function. Can we fix the kubernetes e2e version to 1.19?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should work. This could go into .prow.sh as in kubernetes-csi/external-snapshotter#471

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pohly . Can you file a new PR that is based on kubernetes-csi/external-snapshotter#471?

labels:
preset-service-account: "true"
preset-dind-enabled: "true"
Expand Down Expand Up @@ -275,7 +275,7 @@ presubmits:
optional: true
decorate: true
skip_report: false
skip_branches: ["^(k8s_1.12.0-beta.1|release-0.4|release-1.0)$"]
skip_branches: ["^(k8s_1.12.0-beta.1|release-0.4|release-1.0|release-2.1)$"]
labels:
preset-service-account: "true"
preset-dind-enabled: "true"
Expand Down