Skip K8s 1.20 tests for [email protected] branch #20792
Conversation
Signed-off-by: ialidzhikov <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @ialidzhikov. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -183,7 +183,7 @@ presubmits: | |||
| optional: true | |||
| decorate: true | |||
| skip_report: false | |||
| skip_branches: ["^(k8s_1.12.0-beta.1|release-0.4|release-1.0)$"] | |||
| skip_branches: ["^(k8s_1.12.0-beta.1|release-0.4|release-1.0|release-2.1)$"] | |||
There was a problem hiding this comment.
These files are generated automatically. The https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-csi/gen-jobs.sh script has to be updated to exclude branches on a per-job basis.
There's currently no mechanism in the script to configure that and I don't have a good idea for how to add it.
/hold
There was a problem hiding this comment.
Sorry I don't think skipping the job entirely is the right fix. Older releases using the beta api should still function. Can we fix the kubernetes e2e version to 1.19?
There was a problem hiding this comment.
That should work. This could go into .prow.sh as in kubernetes-csi/external-snapshotter#471
There was a problem hiding this comment.
Thanks @pohly . Can you file a new PR that is based on kubernetes-csi/external-snapshotter#471?
k8s-ci-robot
added
the
do-not-merge/hold
|
I don't have capacity to continue looking into this issue. I created kubernetes-csi/external-snapshotter#472 that contains some basic information with PRs in which we discussed the issue. /close |
|
@ialidzhikov: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As discussed in kubernetes-csi/external-snapshotter#471, the K8s 1.20 e2e tests are not appropriate for
release-2.1branch ofkubernetes-csi/external-snapshotter- the tests are assuming apiversion v1 but the only available apiversion in kubernetes-csi/[email protected] is v1beta1.