Add tools package, tidy go mods

[mcristina422]

This adds a tools file like https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module

And fixes some changes made in #2280

[k8s-ci-robot]

Hi @mcristina422. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mcristina422]

/assign @mortent

I think #2417 might have caught this. @monopole are there plans to re-enable a similar check?

[monopole]

we can re-enable checks.

some checks have benefits in one area, but cause troubles in others. E.g. maintaining different Go lint checks for different Go modules in this repo is IMO more trouble than simply sticking with one standard for linting across the board. Anyone wanting to increase linting for one module can contribute lint improvements to other modules too.

thanks!
/lgtm

[monopole]

/ok-to-test

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mcristina422
To complete the pull request process, please assign monopole
You can assign the PR to them by writing /assign @monopole in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mcristina422]

@monopole Hmmm, it seems that there is an even larger issue in CI. golangci-lint-kustomize is never called in the output logs.

The top level Makefile is never being executed, as the travis/kyaml-pre-commit.sh script is only running make all in the target subdirectories. I think . needs to be added as a target