Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exlude golangci-lint v1.24.0 which breaks CI #2280

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

yujunz
Copy link
Member

@yujunz yujunz commented Mar 16, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from droot and monopole March 16, 2020 09:20
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 16, 2020
@yujunz
Copy link
Member Author

yujunz commented Mar 16, 2020

Latest version seems breaking the CI job as shown in #2278 (comment)

@yujunz yujunz changed the title Pin golangci-lint version to v1.23.8 Exlude golangci-lint v1.24.0 which breaks CI Mar 16, 2020
@pwittrock
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwittrock, yujunz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@pwittrock
Copy link
Contributor

@yujunz Thanks!

@k8s-ci-robot k8s-ci-robot merged commit 036b93c into kubernetes-sigs:master Mar 17, 2020
@yujunz yujunz deleted the golangci-lint branch March 18, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants