Download golangci-lint instead of building it #226
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @hrak. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XXL
| @@ -21,7 +21,6 @@ package tools | |||
| import ( | |||
| _ "github.com/a8m/envsubst" | |||
| _ "github.com/golang/mock/mockgen" | |||
| _ "github.com/golangci/golangci-lint/cmd/golangci-lint" | |||
There was a problem hiding this comment.
If I'm not mistaken, tools like dependabot will struggle to flag anything not in the manifest.
Do you have any insight?
There was a problem hiding this comment.
Yes, it does mean you will lose dependabot bumps, but it also means we can move forward to Go 1.19 / 1.20, use the recommended way of installing it, and do it the same as most other CAPI related projects (See 1 2)
trying to install a recent version using go build / go install on Go >= 1.19 results in import "github.com/t-yuki/gocover-cobertura" is a program, not an importable package
There was a problem hiding this comment.
Ah, that's painful. Thanks!
hrak
requested review from
chrisdoherty4
and removed request for
dims and
davidjumani
|
A little more on the issue this is trying to solve: ryancurrah/gomodguard#33 Another way of working around the issue is shown here where they've changed the build tag for the tools to be something other than |
|
/lgtm |
|
@chrisdoherty4: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
lgtm
Signed-off-by: Hans Rakers <[email protected]>
hrak
force-pushed
the
golangci-lint-download
branch
from
be57597 to
62fac75
Compare
k8s-ci-robot
removed
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chrisdoherty4, hrak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thank you for your contributions @hrak. |
|
@hrak: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of changes:
This PR downloads golangci-lint instead of building it, as recommended by the authors of golangci-lint, and similar to how its done in CAPI
The PR also bumps the version of golangci-lint from v1.46.2 to v1.51.2 and staticcheck from v0.3.1 to 2023.1.2 (v0.4.2)
This will also eventually be required for upgrading the clusterapi dependency, because while testing with clusterapi 1.2.11 i had to update to minimal go 1.19, which required a golangci-lint update, and ran into the issue outlined here .
Testing performed:
make buildBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.