Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(registry_image): consider .dockerignore in image build #240

Merged
merged 3 commits into from
Jul 7, 2021
Merged

fix(registry_image): consider .dockerignore in image build #240

merged 3 commits into from
Jul 7, 2021

Conversation

mavogel
Copy link
Contributor

@mavogel mavogel commented Jun 30, 2021 •
edited
Loading

  • consider the presence of a .dockerignore file in the context path
  • add tests

Note: we'd reuse the tar building form here https://github.com/moby/moby/blob/v20.10.7/pkg/archive/archive.go#L738 as the docker_image already does

@mavogel mavogel added this to the v2.14.0 milestone Jun 30, 2021
@mavogel mavogel linked an issue Jun 30, 2021 that may be closed by this pull request
Error: Provider produced inconsistent final plan #133
Closed
@mavogel mavogel mentioned this pull request Jun 30, 2021
Closed
@mavogel mavogel self-assigned this Jun 30, 2021
@mavogel mavogel requested a review from suzuki-shunsuke June 30, 2021 13:36
@mavogel mavogel merged commit b759b8f into master Jul 7, 2021
@mavogel mavogel deleted the fix/registry-image-context branch July 7, 2021 08:35
@mavogel mavogel mentioned this pull request Jul 11, 2021
Closed
@moritzheiber moritzheiber mentioned this pull request Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-shunsuke suzuki-shunsuke Awaiting requested review from suzuki-shunsuke

Assignees

@mavogel mavogel

Labels
None yet
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.

Error: Provider produced inconsistent final plan
1 participant
@mavogel