docker_registry_image fails to exclude files listed in .dockerignore

[moritzheiber]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and docker Provider) Version

terraform -v
Terraform v1.0.5
on linux_amd64

Provider version is 2.15.0.

Affected Resource(s)

• docker_registry_image

Terraform Configuration Files

I've created a POC repository which allows for reproducing the bug: https://github.com/moritzheiber/terraform-docker-provider-dockerignore

Expected Behaviour

The files added to the .dockerignore file are not contained within the resulting image.

Actual Behaviour

The files added to the .dockerignore file are contained within the resulting image.

Steps to Reproduce

See the README.md in the POC repository.

References

• fix(registry_image): consider .dockerignore in image build #240

Also, taking a look at the test for this particular functionality, the Dockerfile used for it doesn't have a broad instruction for adding files into the image, which means the ignored file cannot possible ever show up in the image itself, leading me to believe the test itself is not sufficient in order to verify the given functionality.

[github-actions]

This issue is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
If you don't want this issue to be closed, please set the label pinned.

[moritzheiber]

Uhm, this issue has been marked as a target for 2.16.0, it shouldn’t even be marked as stale..?

[moritzheiber]

@mavogel some help? 😅

[marcelmeulemans]

The issue here is that absolute paths are passed to the excludes matcher. I would create a PR but not being proficient in go is preventing me from fixing the associated unit test. The unit test currently does not really check the ignore behaviour because the file being modified in the test here was not even copied to the image.

[mavogel]

sure @moritzheiber feel free to help :)