Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 libs/ui CI build on push #7702

Merged
merged 10 commits into from
Oct 24, 2023
Merged

🔧 libs/ui CI build on push #7702

merged 10 commits into from
Oct 24, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 17, 2023

Goes after #7701

ref #4464

New workflow to build libs/ui package each time we edit files

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit cb7628c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65376622e184fc0008f8e067
😎 Deploy Preview https://deploy-preview-7702--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 17, 2023

AI-Generated Summary: This pull request contains changes across several files, most of which include rearranging import orders, adding the computed import from 'vue', and integrating the '@vueuse/core' package.

There's a noticeable trend of replacing the '@google/model-viewer' package, which is confirmed by its removal from the pnpm-lock.yaml and package.json files. In MediaItem.vue, '@google/model-viewer' was replaced with a script link to the library in the useHead block. Moreover, several other dependencies related to '@google/model-viewer' have also been removed.

The addition of the 'vue' and '@vueuse/core' imports is pervasive in most of the Vue component files like NFTMediaInfo.vue, NeoStickyModal.vue, NeoSteps.vue, NeoTooltip.vue, NeoAvatar.vue, NeoCheckbox.vue, NeoNftCard.vue, NeoAudioPlayer.vue, NeoModal.vue, VideoMedia.vue, NeoModalHead.vue, and NeoWaveform.vue.

Most of these changes aim to enhance the overall readability of the codebase and improve the management of dependencies. There is a shift from using 'google/model-viewer' to '@vueuse/core'. There is a focus on improving reactiveness in components, as seen with the addition of computed and ref and changes in the isInteractive constant in MediaItem.vue.

Also, a new GitHub Actions workflow configuration file named 'build.libs-ui.yml' has been added, which is triggered on every push to the main branch for changes in the 'libs/ui/**' path.

In NeoDropdown.story.vue, there's a structural change for better structuring and manageability. The diff for NeoNftCard.vue pertains to the rearrangement of import orders, with no functional alterations. In NeoAvatar.story.vue, the image URL has been updated without altering functionality.

Lastly, the revisions in MediaItem.story.vue have updated the media source URLs for different media types in the MediaItem component.

@reviewpad reviewpad bot added the medium Pull request is medium label Oct 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 17, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo requested a review from preschian October 17, 2023 10:40
@yangwao yangwao marked this pull request as ready for review October 17, 2023 15:45
@yangwao yangwao requested a review from a team as a code owner October 17, 2023 15:45
@yangwao yangwao requested review from Jarsen136 and removed request for a team October 17, 2023 15:45
@reviewpad reviewpad bot added small Pull request is small and removed medium Pull request is medium labels Oct 17, 2023
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reviewpad reviewpad bot added large Pull request is large and removed small Pull request is small labels Oct 18, 2023
@socket-security
Copy link

socket-security bot commented Oct 18, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@reviewpad reviewpad bot removed the large Pull request is large label Oct 23, 2023
@reviewpad reviewpad bot added the medium Pull request is medium label Oct 23, 2023
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Oct 24, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 24, 2023

Code Climate has analyzed commit cb7628c and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@roiLeo roiLeo enabled auto-merge October 24, 2023 06:38
@roiLeo roiLeo added this pull request to the merge queue Oct 24, 2023
Merged via the queue into kodadot:main with commit 78a3b02 Oct 24, 2023
12 checks passed
@roiLeo roiLeo deleted the chore/ci/ui branch October 24, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants