Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 libs/ui errors & warning #7701

Merged
merged 2 commits into from
Oct 17, 2023
Merged

🔧 libs/ui errors & warning #7701

merged 2 commits into from
Oct 17, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 17, 2023 •
edited
Loading

Last issue I can't fix is (fixed in #7702):

Capture d’écran 2023-10-17 à 12 15 22 PM

IMO model-viewer need to be imported as script tag (instead of package) to fix this one.

@roiLeo roiLeo requested a review from a team as a code owner October 17, 2023 10:23
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team October 17, 2023 10:23
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d60f4cf
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/652e91ee2309f10008b8bb4c
😎 Deploy Preview https://deploy-preview-7701--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 17, 2023

AI-Generated Summary: This pull request introduces several changes mainly pertaining to the 'libs/ui' files. Most notably, it adds '@vueuse/core' as a dependency in the 'libs/ui/package.json'. It modifies multiple Vue component files in the 'libs/ui/src/components' directory like 'MediaItem.vue', 'AudioMedia.vue', 'VideoMedia.vue', 'NeoAudioPlayer.vue', 'NeoAvatar.vue', and others. The changes in these files generally involve import updates and the addition or modification of Vue.js function declarations. Changes to the 'MediaItem.story.vue' show that it replaces URL strings throughout the code. In the 'package.json' file, it removes '@google/model-viewer' from the dependencies.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 17, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo mentioned this pull request Oct 17, 2023
Merged
@codeclimate
Copy link

codeclimate bot commented Oct 17, 2023

Code Climate has analyzed commit d60f4cf and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@yangwao yangwao merged commit fa839bd into kodadot:main Oct 17, 2023
11 checks passed
This was referenced Oct 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roiLeo @daiagi @yangwao