Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎩 refactoring scss archi #3804

Merged
merged 6 commits into from
Aug 23, 2022
Merged

🎩 refactoring scss archi #3804

merged 6 commits into from
Aug 23, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 23, 2022 •
edited
Loading

bobross-lede-1

PR type

  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

@roiLeo roiLeo requested review from a team as code owners August 23, 2022 10:02
@roiLeo roiLeo requested review from Jarsen136 and JustLuuuu and removed request for a team August 23, 2022 10:02
@netlify
Copy link

netlify bot commented Aug 23, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit dda255a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6304bf99de0099000885443c
😎 Deploy Preview https://deploy-preview-3804--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo marked this pull request as draft August 23, 2022 10:02
@roiLeo roiLeo marked this pull request as ready for review August 23, 2022 11:05
@roiLeo roiLeo marked this pull request as draft August 23, 2022 11:08
@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 23, 2022

Just checked preview and it's pretty bad lol

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

Just checked preview and it's pretty bad lol

@vikiival vikiival linked an issue Aug 23, 2022 that may be closed by this pull request
Refactor CSS #1348
Closed
@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

Just checked preview and it's pretty bad lol

almost hit merge lol

@vikiival
Copy link
Member

Just checked preview and it's pretty bad lol

If the preview was a cat

@roiLeo roiLeo marked this pull request as ready for review August 23, 2022 11:37
@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 23, 2022

Just checked preview and it's pretty bad lol

nft-gallery/styles/index.scss

Line 5 in 27411ad

// FRAMEWORK (note: don't move this on top)
or feel free to move this if you want to break stuff

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2022

Code Climate has analyzed commit dda255a and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

I feel lucky

@yangwao yangwao merged commit cfabd07 into kodadot:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

@JustLuuuu JustLuuuu Awaiting requested review from JustLuuuu JustLuuuu was automatically assigned from kodadot/qa-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor CSS
3 participants
@roiLeo @yangwao @vikiival