Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: first batch of landing page improvements #2815

Merged
merged 5 commits into from
Apr 12, 2022
Merged

refactor: first batch of landing page improvements #2815

merged 5 commits into from
Apr 12, 2022

Conversation

kkukelka
Copy link
Member

@kkukelka kkukelka commented Apr 10, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kkukelka kkukelka requested a review from a team as a code owner April 10, 2022 16:48
@kkukelka kkukelka requested review from prachi00 and removed request for a team April 10, 2022 16:48
@netlify
Copy link

netlify bot commented Apr 10, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 1f6e56a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/625513671c222d000990cdb8
😎 Deploy Preview https://deploy-preview-2815--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao
Copy link
Member

yangwao commented Apr 10, 2022 •
edited
Loading

What are improvements inside 😜

@kkukelka
Copy link
Member Author

What improvements inside 😜

no legacy js, lazy imports of landing page components, modern image formats & fixed sizes, few seo & a11y stuff

@kkukelka
Copy link
Member Author

@yangwao wrote a list of all iterations that will have to be made to improve pagespeed #2816

@yangwao
Copy link
Member

yangwao commented Apr 11, 2022

I've tested this meanwhile and found improvements!

Let's merge this tho! :)

@prachi00
Copy link
Member

@kkukelka merge conflicts

@kkukelka kkukelka requested a review from prachi00 April 12, 2022 05:52
@prachi00
Copy link
Member

pay 200 usd

@yangwao
Copy link
Member

yangwao commented Apr 12, 2022

😍 Perfect, I’ve sent the payout
💵 $200 @ 155.81 USD/KSM ~ 1.284 $KSM
🧗 EqdyzrzVmeHwMdMwvPeCMnNdbuQDbD3YrjY93xq9Ln3jUGW
🔗 0x4f6ee9b467d40c2681471a6681245984c30789de8a3ef13b7aeaddde1a48884b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 12, 2022
@prachi00 prachi00 merged commit 4deb1f8 into kodadot:main Apr 12, 2022
@yangwao yangwao mentioned this pull request Apr 12, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prachi00 prachi00 prachi00 approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix lighthouse report
3 participants
@kkukelka @yangwao @prachi00