Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lighthouse report #474

Closed
2 tasks
Tracked by #2816
vikiival opened this issue Jun 18, 2021 · 11 comments · Fixed by #2815
Closed
2 tasks
Tracked by #2816

Fix lighthouse report #474

vikiival opened this issue Jun 18, 2021 · 11 comments · Fixed by #2815
Labels
$ ~<50usd $$ ~51-150usd good first issue as new commer, something you could start with p2 core functionality, or is affecting 60% of app

Comments

@vikiival
Copy link
Member

Currently KodaDot has not so good lighthouse stats.

Screenshot 2021-06-18 at 11 57 45

Deliverables:

  • Fix performance
  • Optional: fix other fields
@vikiival vikiival added $ ~<50usd p4 affecting less than 10% of app labels Jun 18, 2021
@yangwao
Copy link
Member

yangwao commented Jul 1, 2021

That's just time to load the bundle?

@AndreyGrin AndreyGrin mentioned this issue Aug 28, 2021
Merged
@yangwao yangwao added p3 non-core, affecting less than 40% $$ ~51-150usd and removed p4 affecting less than 10% of app labels Sep 2, 2021
@yangwao
Copy link
Member

yangwao commented Sep 2, 2021 •
edited
Loading

I guess it's getting a bit worse at my side.
Topped up to p3 and $$:)
We want to see at least 80 for performance for the mobile lighthouse report and 100 points for rest categories.

image

@ksbek
Copy link
Contributor

ksbek commented Sep 2, 2021

@yangwao I can handle this issue. Please assign me this issue.

@yangwao
Copy link
Member

yangwao commented Sep 5, 2021

On desktop gives me 63
image

Mobile 35
image

So hope we can optimize something on the bundle, somehow :)

@yangwao
Copy link
Member

yangwao commented Sep 16, 2021

Hello, @ksbek any progress on this?

@yangwao
Copy link
Member

yangwao commented Sep 16, 2021

Meanwhile checking that it's time to cut bundle as average build time is.. quite high
image

@yangwao yangwao added the good first issue as new commer, something you could start with label Sep 21, 2021
@yangwao
Copy link
Member

yangwao commented Sep 21, 2021

This issue is free for grab and quite important for us to keep it rolling checking on bundle.

@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Sep 21, 2021
This was referenced Sep 21, 2021
Closed
Closed
@yangwao
Copy link
Member

yangwao commented Oct 7, 2021 •
edited
Loading

Interesting, deploy previews are 2m20s--3m40s, where production builds are somehow higher, maybe caching layers in docker netlify uses?

previews production
image image

@yangwao
Copy link
Member

yangwao commented Apr 5, 2022

On desktop gives me 63 image

image

Mobile 35 image

image

Seems how we load landing page impacted performance a lot.

@vikiival
Copy link
Member Author

vikiival commented Apr 6, 2022

Seems how we load landing page impacted performance a lot.

👀 may some async loading would be oki for this

This was referenced Apr 10, 2022
Merged
Open
@kkukelka
Copy link
Member

created metaissue to track progress on this one #2816

@yangwao yangwao mentioned this issue Jun 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd $$ ~51-150usd good first issue as new commer, something you could start with p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: first batch of landing page improvements kkukelka/nft-gallery
4 participants
@yangwao @kkukelka @ksbek @vikiival