-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add first version of kodadot style guide 💅 #2733
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the first draft, really nice
Hey, I wanted to introduce in #2492 nuxt way to fetch data since we don't use It would be something like this: import { Component } from 'nuxt-property-decorator'
@Component({
components: {
Component: () => import('@/components/Component.vue'),
},
async asyncData({ app, $config, params }) {
const res = await app?.apolloProvider?.clients[$config.prefix].query({
query: queryGql,
variables: {
id: params.id
},
})
return {
data: res.data,
total: res.total,
}
}
})
export default class ClassName extends Vue {
data?: Type
total?: Type
[...]
} |
perfect! ill add it asap. should be considered best practice for every new page we build. |
3abb027
to
209a06c
Compare
I would add note for this one line if ❗ bad if (something) return 1 ✅ good if (something) {
return 1
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
pay 100 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot