Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move broker defaults into core #2947

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Move broker defaults into core #2947

merged 1 commit into from
Apr 9, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented Apr 9, 2020

Fixes #2945

Proposed Changes

  • Move broker configs into config/core.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 9, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2020
@aliok
Copy link
Member Author

aliok commented Apr 9, 2020

/assign @matzew

@matzew
Copy link
Member

matzew commented Apr 9, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
@knative-prow-robot knative-prow-robot merged commit 33a13ea into knative:master Apr 9, 2020
@aliok aliok deleted the broker-defaults-in-core branch April 9, 2020 10:02
This was referenced Apr 9, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslom aslom Awaiting requested review from aslom

@Harwayne Harwayne Awaiting requested review from Harwayne

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing broker defaults in eventing.yaml
4 participants
@aliok @matzew @knative-prow-robot @googlebot