Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing broker defaults in eventing.yaml #2945

Closed
aliok opened this issue Apr 9, 2020 · 3 comments · Fixed by #2947
Closed

Missing broker defaults in eventing.yaml #2945

aliok opened this issue Apr 9, 2020 · 3 comments · Fixed by #2947
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@aliok
Copy link
Member

aliok commented Apr 9, 2020

Describe the bug
After #2936, when I build the release yamls using ./hack/release.sh --skip-tests, I don't see config-br-default-channel and config-br-defaults in the release manifest `eventing.yaml.

Expected behavior
Default broker config to be included in the release manifest, eventing.yaml.

Contents of these 2 files should be in the output:

  • 400-config-br-default-channel.yaml
  • 400-config-br-defaults.yaml.

To Reproduce
Do ./hack/release.sh --skip-tests, check the resulting eventing.yaml file.

Knative release version
0.13

Additional context
Basically the comment: #2936 (comment)

@aliok aliok added the kind/bug Categorizes issue or PR as related to a bug. label Apr 9, 2020
@aliok
Copy link
Member Author

aliok commented Apr 9, 2020

Could be 2 ways to fix it:

  • Adding 400-config-br-default-channel.yaml and 400-config-br-defaults.yaml to the release manifest manually:
    ["eventing.yaml"]="eventing-core.yaml channel-broker.yaml mt-channel-broker.yaml in-memory-channel.yaml"
  • Moving those files back, but only having them in channel-broker

@matzew
Copy link
Member

matzew commented Apr 9, 2020

@aliok

my bad!

need to go into core folder

and the two 400-config-br-XXXX should be symlinks to that - OK ?

Can you PR that ?

@aliok
Copy link
Member Author

aliok commented Apr 9, 2020

That's a better solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants