feat:Chromium support for Linux, Darwin and Windows #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Chromium for Darwin and Windows platforms Remove linux chromium binary lookup in Google Chrome Closes karma-runner#45
gmoz22
changed the title
|
please rebase this against master thanks! |
|
+1 on removing chromium from chrome 'target'. Just had a problem in my system where jasmine tests were passing locally under Chrome, but failing on remote Continuous Integration system. Root cause was that CI system was using Chromium to run tests (and failing), rather than Chrome. Current fix is to revert back to using [email protected] |
|
@gmoz22 ping, re rebase onto master and please change to commit message to follow our guidelines |
|
@gmoz22 another ping |
|
Closing this due to lack of feedback from the PR author. This issue was fixed and merged in #69. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Chromium for Linux, Darwin and Windows platforms
Remove linux chromium binary lookup in Google Chrome
Closes #45