Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium support for Darwin and Windows #45

Closed
gmoz22 opened this issue May 5, 2015 · 4 comments
Closed

Chromium support for Darwin and Windows #45

gmoz22 opened this issue May 5, 2015 · 4 comments

Comments

@gmoz22
Copy link

gmoz22 commented May 5, 2015

Version 0.1.8 supports Chromium on linux but not on Darwin and Windows.

gmoz22 added a commit to gmoz22/karma-chrome-launcher that referenced this issue May 5, 2015
Add support for Chromium for Darwin and Windows platforms
Remove linux chromium binary lookup in Google Chrome
Closes karma-runner#45
@j0hnsmith
Copy link

+1

1 similar comment
@sechel
Copy link

sechel commented Feb 26, 2016

+1

@Ciantic
Copy link

Ciantic commented Apr 3, 2016

It's quiet simple to hack it to work by editing karma-chrome-launcher in node_modules:
https://github.com/karma-runner/karma-chrome-launcher/blob/master/index.js#L48

But I think there could be a option "chromePath" where one could define absolute path to chromium. In windows it's usually not installed, but unzipped in random location, so having such elaborate guessing algorithm is not working.

@Ciantic
Copy link

Ciantic commented Apr 3, 2016

Found a workaround, which is a good one, just throw this in top of your "karma.conf.js":

process.env['CHROME_BIN'] = "C:\\Copies\\Chromium\\chrome.exe";

No need to monkey patch.

haifengkao added a commit to haifengkao/karma-chrome-launcher that referenced this issue Apr 12, 2016
Add support for Chromium for Linux, Darwin and Windows platforms
Remove linux chromium binary lookup in Google Chrome
Closes karma-runner#45
haifengkao added a commit to haifengkao/karma-chrome-launcher that referenced this issue Aug 18, 2016
Add support for Chromium for Linux, Darwin and Windows platforms
Remove linux chromium binary lookup in Google Chrome
Closes karma-runner#45

fix grunt errors

update readme
dignifiedquire pushed a commit that referenced this issue Aug 18, 2016
Add support for Chromium for Linux, Darwin and Windows platforms
Remove linux chromium binary lookup in Google Chrome

Closes #45

BREAKING: Chromium needs to be explicitly enabled now
wmfphab pushed a commit to wikimedia/mediawiki that referenced this issue Jan 12, 2017
Before karma-chrome-launcher 2.0.0, Chromium was only detected on Linux
and as part of the "Chrome" setting. "Chromium" is now recognised as a
separate browser and is detected on Mac and Windows as well.

karma-runner/karma-chrome-launcher#45

Add a grunt target for Chromium so users may run the following to use
Chromium instead of Chrome:

    grunt karma:chromium

Since we keep the default of "Chrome", we'll need an override for CI
since we install Chromium there instead of Chrome.

Depends on Ie9f906f8 being merged and Nodepool images updated.

Bug: T153756
Change-Id: I6ba0d971e7e8c3022d2ab6268ae637688189d768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants