Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming ConvEmformer model #49

Merged
merged 14 commits into from
Jul 12, 2022
Merged

Conversation

yaozengwei
Copy link
Collaborator

This PR implements using the streaming ConvEmformer model (See k2-fsa/icefall#440).

@@ -0,0 +1,246 @@
# Copyright 2022 Xiaomi Corp. (authors: Fangjun Kuang)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2022 Xiaomi Corp. (authors: Fangjun Kuang)
# Copyright 2022 Xiaomi Corp. (authors: Zengwei Yao)

Comment on lines 72 to 73
auto states_tuple = torch::ivalue::Tuple::create(
std::get<0>(states), std::get<1>(states));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto states_tuple = torch::ivalue::Tuple::create(
std::get<0>(states), std::get<1>(states));
auto states_tuple = torch::ivalue::Tuple::create(
states.first, states.second);

is shorter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Collaborator

@pkufool pkufool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to add a github CI workflow for this model too.

@yaozengwei
Copy link
Collaborator Author

It would be better to add a github CI workflow for this model too.

Thanks. Done.

@yaozengwei yaozengwei merged commit 43f84f3 into k2-fsa:master Jul 12, 2022
@csukuangfj csukuangfj mentioned this pull request Jul 20, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants