-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming ConvEmformer model #49
Conversation
@@ -0,0 +1,246 @@ | |||
# Copyright 2022 Xiaomi Corp. (authors: Fangjun Kuang) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Copyright 2022 Xiaomi Corp. (authors: Fangjun Kuang) | |
# Copyright 2022 Xiaomi Corp. (authors: Zengwei Yao) |
auto states_tuple = torch::ivalue::Tuple::create( | ||
std::get<0>(states), std::get<1>(states)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto states_tuple = torch::ivalue::Tuple::create( | |
std::get<0>(states), std::get<1>(states)); | |
auto states_tuple = torch::ivalue::Tuple::create( | |
states.first, states.second); |
is shorter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to add a github CI workflow for this model too.
Thanks. Done. |
This PR implements using the streaming ConvEmformer model (See k2-fsa/icefall#440).