-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Qtconsole work on Python 3.8 and Windows #406
Conversation
@minrk, shouldn't this be solved in ipykernel? Or is it necessary to patch every Jupyter application like this? |
@minrk, do you have any view on this? |
What is the way forward to get the qtconsole fixed on windows/python 3.8? |
@ericpre, please merge with master to get the fix to our tests. We'll include your work in our next release (sorry for the delay). |
Done. |
Thanks! @dalthviz will be in charge of reviewing and testing this on Windows. |
Hi @ericpre @ccordoba12 with this fix QtConsole works for me on Windows with Python 3.8 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As described in #405, the qtconsole is currently not working on windows. As a workaround, this PR sets the default asyncio policy on windows with python 3.8 when the app object is created.
For more details, see ipython/ipykernel#480 and tornadoweb/tornado#2608.
Fixes #405.