Workaround tornado+py38+windows compatibility issue #480
Conversation
|
Thanks for this PR! I don't believe the patch belongs in the base IPythonKernel object, which is usually instantiated too late for this to work (the example is pretty minimal, in which case this is early enough, but most 'real' applications will have already selected and started the event loop, in which case this won't work). I think maybe putting a similar fix into the example app itself might be better. The patch in #456 is in the Application object, which is where setting up the eventloop should normally occur. |
…python#456). Set eventloop policy to the old default while tornado is not compatible with the new one." This reverts commit 06967ee.
|
Thanks for the reply, I reverted and updated the example accordingly. |
|
CI failures seem to be due to a faulty version of Pytest; a patch was issued and released; so I restarted the test; which should fix everything. |
|
Test are passing, and this is only in examples; so merging. Thanks. |
The example inprocess_qtconsole.py is not working with python 3.8 on windows and this PR make it work.
Similar fix as #456: set eventloop policy to the old default while tornado is not compatible with the new one.
I don't follow how this works, so I don't know if this is the right fix (just tried to work out where to put the fix from #456) but at least it should highlight where the issue is! ;)