Feature/sync api #44
Merged
Feature/sync api #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 24, 2022 00:34
* main: (23 commits) chore(release): updated release notes and package versions [ci skip] fix(observable): uses ReplaySubject for transforms chore(release): updated release notes and package versions [ci skip] Fix: avoid skipping link entries in submenus (#42) chore(release): updated release notes and package versions [ci skip] Fix: avoid skipping link entries in menus builder (#41) ci(tests): disable shallow clone in github actions workflow ci(tests): tweaks coverage exclusions in sonar.properties ci(tests): tweaks sonar.properties ci(tests): tweaks sonar.properties ci(tests): tweaks sonar.properties ci(tests): tweaks sonar properties ci(tests): adds sonarcloud to test.yml (#40) fix(tests): adds sonar reporter ci(tests): adds sonarqube to test.yml chore(release): updated release notes and package versions [ci skip] feat(utils): adds waitFor util (#39) chore(release): updated release notes and package versions [ci skip] Feature: enable custom hugo menu (#38) chore(release): updated release notes and package versions [ci skip] ...
tharders
reviewed
May 17, 2022
|
|
||
| export const fetch = async (context: RuntimeContext, config: Config) => { | ||
| const content = await getContent(config as ContentfulConfig); | ||
| const { locales, contentTypes } = content; | ||
|
|
||
| // Add entries linked to deleted assets & entries to the list of changed entries | ||
| const additionalEntriesPromise = [ |
There was a problem hiding this comment.
Müsste additionalEntriesPromises sein (Mehrzahl)
| return join(directory, filename); | ||
| }; | ||
|
|
||
| export const write = async ( |
There was a problem hiding this comment.
So viel Änderungen und keine Änderung am Test?
There was a problem hiding this comment.
an den tests bin ich noch dran ;)
| @@ -105,6 +105,7 @@ | |||
| "@endemolshinegroup/cosmiconfig-typescript-loader": "^3.0.2", | |||
| "@iarna/toml": "^2.2.5", | |||
| "@swc-node/register": "^1.4.0", | |||
| "async-exit-hook": "^2.0.1", | |||
There was a problem hiding this comment.
Die lib ist nicht mehr maintained. :-(
Da sie keine Dependencies hat ist das nicht ganz so schlimm, aber in der Beschreibung steht was, dass das auf Windows noch nicht so richtig supported wird.
Wir können auch im Auge behalten, dass das originale 'exit-hook' vielleicht bald async exit hooks erlaubt sindresorhus/exit-hook#20
tharders
reviewed
May 18, 2022
|
Kudos, SonarCloud Quality Gate passed! |
bezoerb
added a commit
that referenced
this pull request
Jun 21, 2022
* Feature/sync api (#44) * feat: add watch mode * feat(watch): adds watch server + auto-hook * fix(watch): pass all observables & entries to subsequent calls * feat(watch): remove files for deleted entries in watch mode * fix(watch): cleanup * docs(watch): adds watch documentation to readme * fix(watch): removes default x-powered-by header from express * test(watch): adds tests * test(watch): fix linter * test(watch): adds tests * fix(watch): don't process.exit in watch mode * test(watcher): adds tests * fix(watch): removes debug log * fix(types): removes duplicate type * ci: refactores jest & typescript config * ci(monorepo): adds turborepo * test(cssg-plugin-assets): adds test for assets plugin * fix: bumps fs-extra * fix(cssg-plugin-assets): adds contentful-ssg devdependency * Feature/turborepo (#46) * ci: refactores jest & typescript config * ci(monorepo): adds turborepo * test(cssg-plugin-assets): adds test for assets plugin * fix: bumps fs-extra * fix(cssg-plugin-assets): adds contentful-ssg devdependency * ci: tweaks sonarcloud settings * test(contentful-fakes): adds tests for contentful-fakes * test(contentdul-fakes): adds tests * fix(watcher): fix port when url is passed * chore(release): updated release notes and package versions [ci skip] * fix: tweak turbo.json * style: trigger rebuild * chore(release): updated release notes and package versions [ci skip] * test(cssg-plugin-assets): adds some tests * fix(sonar): adds cobertura coverage reporter * ci(sonar): tweaks sonar settings * ci(sonar): try sonar.flex.cobertura.reportPaths * fix(test): adds missing coverage reporters * ci(sonar): tweak properties * ci(sonar): adds index.js to cssg-plugin-assets tsconfig.json * fix(watcher): adds option to overwrite watch port * fix(test): without crypto * fix(watch): use crypto for webhook id * chore(release): updated release notes and package versions [ci skip] * ci(sonar): debug coverage * fix(sonar): fix coverage stats * fix(contentful): prefer sha1 over md5 * fix(watcher): allow url & port to be set via environment variable * chore(release): updated release notes and package versions [ci skip] * chore(release): updated release notes and package versions [ci skip] * fix(watcher): use url from environment variable * chore(release): updated release notes and package versions [ci skip] * Feature/video poster (#47) * style(eslint): adds xo-typescript/space & plugin:prettier/recommended * chore(release): updated release notes and package versions [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements watch mode using the contentful sync api