Fix: avoid skipping link entries in menus builder #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid skipping link type entries in menus builder
|
Kudos, SonarCloud Quality Gate passed!
|
bezoerb
pushed a commit
that referenced
this pull request
May 10, 2022
* main: (23 commits) chore(release): updated release notes and package versions [ci skip] fix(observable): uses ReplaySubject for transforms chore(release): updated release notes and package versions [ci skip] Fix: avoid skipping link entries in submenus (#42) chore(release): updated release notes and package versions [ci skip] Fix: avoid skipping link entries in menus builder (#41) ci(tests): disable shallow clone in github actions workflow ci(tests): tweaks coverage exclusions in sonar.properties ci(tests): tweaks sonar.properties ci(tests): tweaks sonar.properties ci(tests): tweaks sonar.properties ci(tests): tweaks sonar properties ci(tests): adds sonarcloud to test.yml (#40) fix(tests): adds sonar reporter ci(tests): adds sonarqube to test.yml chore(release): updated release notes and package versions [ci skip] feat(utils): adds waitFor util (#39) chore(release): updated release notes and package versions [ci skip] Feature: enable custom hugo menu (#38) chore(release): updated release notes and package versions [ci skip] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes missing link type entries in the
menus.yaml.If there is an entry of type "link", it will have no
contentType, which was the reason why it was filtered out in the menu builder. But such entries already got anidwhich is now be used to get the entry from the entries map to provide the actualcontentType