Skip to content

Commit

Permalink
Fixed bug for non visible instances
Browse files Browse the repository at this point in the history
  • Loading branch information
jnsmalm committed May 9, 2021
1 parent 120183a commit 29dfb89
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.9.5] - 2021-05-09
### Fixed
- Fixed an issue which caused WebGL errors when using instancing.

## [0.9.4] - 2021-05-08
### Added
- Support for creating a `Cubemap` from colors.
Expand Down
2 changes: 0 additions & 2 deletions src/material/standard/standard-shader-instancing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ export class StandardShaderInstancing {
}

updateBuffers(instances: InstancedMesh3D[]) {
instances = instances.filter(i => i.worldVisible)

if (instances.length > this._maxInstances) {
this.expandBuffers(instances.length)
}
Expand Down

0 comments on commit 29dfb89

Please sign in to comment.