Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce Windows GNU target support #43

Merged
merged 1 commit into from
May 6, 2024
Merged

Reintroduce Windows GNU target support #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ We build, test, and provide prebuilt packages for the following targets:
Additional targets that work when building from source:
- aarch64-apple-darwin (M1 Macs, cross-compiled on x86_64.)
- aarch64-unknown-linux-gnu (Raspberry Pi 4b, built on the machine itself.)

Platforms that are not supported and won't build:
- x86_64-pc-windows-gnu (See: [assimp/4686]([https://github.com/assimp/assimp/issues/4868))
- x86_64-pc-windows-gnu

## Installation

Expand Down
6 changes: 1 addition & 5 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,7 @@ fn compiler_flags() -> Vec<&'static str> {
fn lib_names() -> Vec<Library> {
let mut names = Vec::new();

if cfg!(target_os = "windows") && cfg!(target_env = "gnu") {
panic!("Windows GNU is not supported, assimp fails to build for some reason.\nSee https://github.com/assimp/assimp/issues/4868");
} else {
names.push(Library("assimp", static_lib()));
}
names.push(Library("assimp", static_lib()));

if build_assimp() && build_zlib() {
names.push(Library("zlibstatic", "static"));
Expand Down