Reintroduce Windows GNU target support #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assimp historically had problems building for the Windows platform with a GNU toolchain, but those problems have been fixed upstream some time ago. These bindings use the latest assimp release, so they contain those fixes already, and thus there is no point in artificially restricting support for a target that assimp can now deal with. I've tested that indeed this target is supported by cross-compiling a Windows binary with the `mingw-w64` toolchain from a Linux host, and then running it under Wine with no problems.
|
thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assimphistorically had problems building for the Windows platform with a GNU toolchain, but those problems have been fixed upstream some time ago. These bindings use the latestassimprelease, so they contain those fixes already, and thus there is no point in artificially restricting support for a target thatassimpcan now deal with.I've tested that indeed this target is supported by
assimpby cross-compiling the Windows tools binary with themingw-w64toolchain from a Linux host, and then running it under Wine with no problems.