Add a correct way to input a numpy array #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS once accepted and merged, could you please tag the commit on the main branch in order to release the wheels on PyPI? |
Merged
|
I would highly appreciate this feature as well! |
|
@jvavrek please look at this fork https://pypi.org/project/CSF-3DFin/ |
|
Thanks for the comtribution. I have merged the code, and new tag has been created. |
|
This is great! For me, it turned a particularly large calculation from 5.5 minutes to 1.5 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Numpy array input was far from being optimal.
he plumbery with SWIG was previously not correctly put in place. As a result, CSF fallback to the
void CSF::setPointCloud(std::vector<std::vector<float> > points)that pass the numpy array by value and thus makes two a full copies of the numpy array (and convert double coordinates to float).This commit correct this behavior by providing correct SWIG bindings for numpy arrays.