feat: allow test environment to run with preset/transform #8751

Mark1626 · 2019-07-25T21:24:57Z

Summary

Fixes #8479. The exact same approach as #7562.

Using the Runtime create an instance of Transformer
Hijack the require and perform the transform
Remove the hook on require

As of now the logic for the transformation is repeated across jest-cli, jest-runner, jest-runtime packages. Can you give me some inputs on whether it can be extracted to a single location?

Test plan

Existing test cases should not be affected by the change, an additional test where the environment needs to be transformed to pass is added.

e2e/transform-linked-modules/package.json

packages/jest-runner/src/runTest.ts

SimenB · 2019-07-25T21:47:31Z

Can you give me some inputs on whether it can be extracted to a single location?

Hmm, maybe we could stick some abstraction for this into @jest/transform? E.g. requireAndTranspileModule<T extends string>(moduleName: T, config: Config.ProjectConfig): typeof import(T) which sets up pirates and the transform, requires the module, and cleans up? This is off the top of my head, but do you think that'd work?

e2e/__tests__/transform.test.ts

SimenB

Code itself LGTM! Would love to reduce the code duplication as discussed

e2e/__tests__/transform.test.ts

SimenB · 2019-07-25T21:55:09Z

Don't worry about the OOM for circus on CI btw - it's not your fault

jeysal

Code LGTM as well, left a few comments in addition to what Simen said.

e2e/__tests__/transform.test.ts

jeysal · 2019-07-26T16:26:31Z

e2e/transform/transform-environment/__tests__/add.test.js

+ */
+
+it('should add two numbers', () => {
+  expect(1 + 1).toBe(2);


Maybe we should use something from the env here just to be sure that it was properly loaded

e2e/transform-linked-modules/package.json

SimenB

Oops, forgot to submit

packages/jest-transform/src/ScriptTransformer.ts

packages/jest-runtime/package.json

packages/jest-core/src/runGlobalHook.ts

packages/jest-transform/src/ScriptTransformer.ts

packages/jest-runtime/src/cli/index.ts

e2e/transform/transform-environment/environment.ts

e2e/transform/transform-environment/babel.config.js

packages/jest-runner/src/runTest.ts

SimenB

This LGTM, needs to wait for us to start merging breaking changes

Mark1626 · 2019-07-28T10:39:21Z

@SimenB @jeysal Thanks for your patient reviews, learnt a lot from this PR

packages/jest-runtime/src/cli/index.ts

MaximeBernard · 2020-05-20T11:25:17Z

@SimenB Why did the roadmap change from Jest26 to High priority future if the PR is good to go?

SimenB · 2020-05-20T14:07:24Z

Feedback from FB that this was potentially very breaking. Code wise still good to go, I'll sync with peeps at FB to make sure we can land it in 27 🙂

michaelgmcd · 2020-09-25T17:16:24Z

Hey @SimenB, any update on this? Just want to confirm it's on track for v27.

SimenB · 2020-09-27T11:50:55Z

It is 👍

Mark1626 · 2020-11-15T05:37:25Z

@SimenB I rebased it, I had to squash the commits into a single commit to simplify the merge conflict

e2e/transform/transform-environment/environment.ts

e2e/v8-coverage/empty-sourcemap/babel.config.js

zzarcon · 2021-03-24T04:49:03Z

Thanks so much for this change folks! Do you know in which version will this be available? thanks!

SimenB · 2021-03-24T06:54:51Z

You can install jest@next to use it now. It'll be available in Jest 27 whenever it stabilizes (possibly over Easter holidays)

github-actions · 2021-05-10T21:06:49Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

facebook-github-bot added the cla signed label Jul 25, 2019

Mark1626 commented Jul 25, 2019

View reviewed changes

e2e/transform-linked-modules/package.json Show resolved Hide resolved

Mark1626 commented Jul 25, 2019

View reviewed changes

packages/jest-runner/src/runTest.ts Show resolved Hide resolved

SimenB reviewed Jul 25, 2019

View reviewed changes

e2e/__tests__/transform.test.ts Outdated Show resolved Hide resolved

SimenB requested changes Jul 25, 2019

View reviewed changes

SimenB reviewed Jul 25, 2019

View reviewed changes

e2e/__tests__/transform.test.ts Show resolved Hide resolved

jeysal added this to the Jest 25 milestone Jul 26, 2019

jeysal reviewed Jul 26, 2019

View reviewed changes

SimenB reviewed Jul 26, 2019

View reviewed changes

packages/jest-transform/src/ScriptTransformer.ts Outdated Show resolved Hide resolved

Mark1626 commented Jul 27, 2019

View reviewed changes

packages/jest-runtime/src/cli/index.ts Outdated Show resolved Hide resolved

Mark1626 commented Jul 27, 2019

View reviewed changes

e2e/transform/transform-environment/environment.ts Show resolved Hide resolved

SimenB reviewed Jul 27, 2019

View reviewed changes

e2e/transform/transform-environment/babel.config.js Outdated Show resolved Hide resolved

packages/jest-runner/src/runTest.ts Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Mark1626 mentioned this pull request Jul 27, 2019

refactor: Extract transform code to @jest-transform #8756

Merged

SimenB reviewed Jul 27, 2019

View reviewed changes

packages/jest-runner/src/runTest.ts Outdated Show resolved Hide resolved

SimenB reviewed Jul 27, 2019

View reviewed changes

packages/jest-runner/src/runTest.ts Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Mark1626 force-pushed the feature/transform-env branch from ffc8f08 to a2e6f88 Compare July 28, 2019 06:25

Mark1626 mentioned this pull request Jul 28, 2019

fix: Allow setting extra options in this.global for Typescript #8758

Merged

SimenB approved these changes Jul 28, 2019

View reviewed changes

SimenB reviewed Jul 30, 2019

View reviewed changes

packages/jest-runtime/src/cli/index.ts Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Mark1626 force-pushed the feature/transform-env branch from 485de83 to 2571c1f Compare August 8, 2019 14:39

SimenB mentioned this pull request Aug 10, 2019

Support transforming resolves (to allow for .ts-based snapshotResolver) #8330

Closed

Mark1626 mentioned this pull request Aug 11, 2019

Support transforming all modules which can be specified in config #8810

Open

SimenB mentioned this pull request May 11, 2020

Possibility to write testEnvironment in esm #10018

Closed

SimenB modified the milestones: High priority future, Jest 27 May 20, 2020

deklanw mentioned this pull request May 20, 2020

Seems ignore modules required using "require" kulshekhar/ts-jest#1274

Closed

DarkLite1 mentioned this pull request Jun 19, 2020

Using globalSetup and globalTeardown with TypeScript #10178

Closed

chrisdarroch mentioned this pull request Jul 3, 2020

SyntaxError: Cannot use import statement outside a module ionic-team/stencil#2178

Closed

Mark1626 force-pushed the feature/transform-env branch from c4d3387 to a48e7e9 Compare November 15, 2020 05:35

Mark1626 added 3 commits November 15, 2020 17:58

feat: allow test environment to run with preset/transform

407aa6b

chore: fix test, update e2e dep

9a5787a

fix: Fix failing empty-sourcemap test

ab4f9fb

Mark1626 force-pushed the feature/transform-env branch from 4661c8b to ab4f9fb Compare November 15, 2020 12:36

SimenB approved these changes Nov 15, 2020

View reviewed changes

e2e/transform/transform-environment/environment.ts Outdated Show resolved Hide resolved

SimenB reviewed Nov 15, 2020

View reviewed changes

e2e/v8-coverage/empty-sourcemap/babel.config.js Outdated Show resolved Hide resolved

chore: Review changes

e58dd07

SimenB merged commit 7d47fa0 into jestjs:master Nov 15, 2020

SimenB mentioned this pull request Nov 15, 2020

feat: support for transforming runner #8854

Merged

Mark1626 mentioned this pull request Nov 15, 2020

Support transforming testRunner with preset/transform #8823

Merged

ceyhun mentioned this pull request Dec 15, 2020

[RNMobile] Extract duplicate e2e test setup to jest config WordPress/gutenberg#27334

Merged

6 tasks

ahnpnl mentioned this pull request Jan 27, 2021

Babel not transforming custom testEnvironment #11032

Closed

mmarkelov mentioned this pull request Mar 26, 2021

Typescript support for CustomEnvironment playwright-community/jest-playwright#634

Closed

mrazauskas mentioned this pull request Apr 23, 2021

fix: export default in test environments #11335

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow test environment to run with preset/transform #8751

feat: allow test environment to run with preset/transform #8751

Mark1626 commented Jul 25, 2019

SimenB commented Jul 25, 2019

SimenB left a comment

SimenB commented Jul 25, 2019

jeysal left a comment

jeysal Jul 26, 2019

SimenB left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SimenB left a comment

Mark1626 commented Jul 28, 2019

This comment has been minimized.

MaximeBernard commented May 20, 2020

SimenB commented May 20, 2020

michaelgmcd commented Sep 25, 2020 •

edited

Loading

SimenB commented Sep 27, 2020

Mark1626 commented Nov 15, 2020

zzarcon commented Mar 24, 2021

SimenB commented Mar 24, 2021

github-actions bot commented May 10, 2021

feat: allow test environment to run with preset/transform #8751

feat: allow test environment to run with preset/transform #8751

Conversation

Mark1626 commented Jul 25, 2019

Summary

Test plan

SimenB commented Jul 25, 2019

SimenB left a comment

Choose a reason for hiding this comment

SimenB commented Jul 25, 2019

jeysal left a comment

Choose a reason for hiding this comment

jeysal Jul 26, 2019

Choose a reason for hiding this comment

SimenB left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SimenB left a comment

Choose a reason for hiding this comment

Mark1626 commented Jul 28, 2019

This comment has been minimized.

MaximeBernard commented May 20, 2020

SimenB commented May 20, 2020

michaelgmcd commented Sep 25, 2020 • edited Loading

SimenB commented Sep 27, 2020

Mark1626 commented Nov 15, 2020

zzarcon commented Mar 24, 2021

SimenB commented Mar 24, 2021

github-actions bot commented May 10, 2021

michaelgmcd commented Sep 25, 2020 •

edited

Loading