[RNMobile] Extract duplicate e2e test setup to jest config #27334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyhun
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
ceyhun
changed the title
2 tasks
|
I merged in latest from |
|
Thanks @cameronvoell! They failed again so I restarted and now they seem to pass. |
|
@cameronvoell got another merge from master and updated the newly added file block tests. Can you please approve if it looks good. |
| import serverConfigs from './serverConfigs'; | ||
| import { iosServer, iosLocal, android } from './caps'; | ||
| import AppiumLocal from './appium-local'; | ||
| const serverConfigs = require( './serverConfigs' ); |
There was a problem hiding this comment.
Curious why you converted all the import methods to require methods in this file and in packages/react-native-editor/__device-tests__/pages/editor-page.js . Maybe there's a performance gain for importing some of these dynamically at runtime? Feels like maybe theres a reason I'm missing.
There was a problem hiding this comment.
That's a good question! These files are now running in a different jest environment than before, and it's currently not possible to apply the same babel transforms/presets we do to the tests themselves. A PR merged to jest resolves this issue and will hopefully be released in the next versions. jestjs/jest#8751
cameronvoell
approved these changes
Dec 15, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#2846
setupFilesAfterEnvandtestEnvironment.platformVersionversion from iOS local tests to pick up any available simulator version without hardcoding.How has this been tested?
npm run native test:e2e:ios:localandnpm run native test:e2e:android:localshould work as before.Screenshots
Types of changes
Checklist: