Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS2015 fixes #165

Merged
merged 6 commits into from
Sep 5, 2024
Merged

VS2015 fixes #165

merged 6 commits into from
Sep 5, 2024

Conversation

0blu
Copy link
Contributor

@0blu 0blu commented Sep 1, 2024

Fixes the compilation on VS14 / 2015.

@0blu
Copy link
Contributor Author

0blu commented Sep 1, 2024

There are also some warnings when converting from BOOL (aka int) to bool.
Which could be solved with != 0 check. (e.g. return _isatty(fd) != 0;)

jeremy-rifkin
jeremy-rifkin approved these changes Sep 3, 2024
View reviewed changes
Copy link
Owner

@jeremy-rifkin jeremy-rifkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this! I wish it were easier for me to test older versions of compilers in CI to prevent regressions. I'll have to look into doing so later.

src/utils/utils.hpp Outdated Show resolved Hide resolved
src/utils/error.hpp Outdated Show resolved Hide resolved
src/utils/error.hpp Show resolved Hide resolved
src/cpptrace.cpp Outdated Show resolved Hide resolved
jeremy-rifkin
jeremy-rifkin approved these changes Sep 5, 2024
View reviewed changes
Copy link
Owner

@jeremy-rifkin jeremy-rifkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time to do this and working through the review comments! Looks good to me!

@jeremy-rifkin jeremy-rifkin changed the base branch from main to dev September 5, 2024 01:58
@jeremy-rifkin jeremy-rifkin merged commit 0d89be4 into jeremy-rifkin:dev Sep 5, 2024
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremy-rifkin jeremy-rifkin jeremy-rifkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0blu @jeremy-rifkin