VS14 support: Fix MSVC bug with std::enable_if

jeremy-rifkin · Sep 5, 2024 · 391646d · 391646d
1 parent 0cc93bd
commit 391646d
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/utils/utils.hpp b/src/utils/utils.hpp
@@ -496,8 +496,10 @@ namespace detail {
     template<
         typename T,
         typename D
-        // workaround a msvc bug https://developercommunity.visualstudio.com/t/MSVC-1938331290-preview-fails-to-comp/10505565
-        #if !defined(_MSC_VER) || _MSC_VER != 1938
+        // workaround for:
+        //  == 19.38-specific msvc bug https://developercommunity.visualstudio.com/t/MSVC-1938331290-preview-fails-to-comp/10505565
+        //  <= 19.23 msvc also appears to fail (but for a different reason https://godbolt.org/z/6Y5EvdWPK)
+        #if !defined(_MSC_VER) || !(_MSC_VER <= 1923 || _MSC_VER == 1938)
          ,
          typename std::enable_if<
              std::is_same<decltype(std::declval<D>()(std::declval<T>())), void>::value,