Remove empty args from argument_list in SubprocessCompiler #590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argument_list
does not check if the first element is empty, which is problematic because, by default, that is the program that will be executed bysubprocess.Popen
, so, for example, if the first element inargument_list
is an empty string, then aPermissionError
will be raised. This came up when working with django-pipeline-browserify, because the first element in the commandBrowserifyCompiler
passes toexecute_command
isBROWSERIFY_VARS
, which defaults to''
. This commit will filter out empty elements inargument_list
to prevent issues like this.